lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20211015233028.2167651-4-mcgrof@kernel.org> Date: Fri, 15 Oct 2021 16:30:22 -0700 From: Luis Chamberlain <mcgrof@...nel.org> To: axboe@...nel.dk, jejb@...ux.ibm.com, martin.petersen@...cle.com, agk@...hat.com, snitzer@...hat.com, colyli@...e.de, kent.overstreet@...il.com, boris.ostrovsky@...cle.com, jgross@...e.com, sstabellini@...nel.org, roger.pau@...rix.com, geert@...ux-m68k.org, ulf.hansson@...aro.org, tj@...nel.org, hare@...e.de, jdike@...toit.com, richard@....at, anton.ivanov@...bridgegreys.com, johannes.berg@...el.com, krisman@...labora.com, chris.obbard@...labora.com, thehajime@...il.com, zhuyifei1999@...il.com, haris.iqbal@...os.com, jinpu.wang@...os.com, miquel.raynal@...tlin.com, vigneshr@...com, linux-mtd@...ts.infradead.org Cc: linux-scsi@...r.kernel.org, dm-devel@...hat.com, linux-bcache@...r.kernel.org, xen-devel@...ts.xenproject.org, linux-m68k@...ts.linux-m68k.org, linux-um@...ts.infradead.org, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org> Subject: [PATCH 3/9] dm: add add_disk() error handling We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. There are two calls to dm_setup_md_queue() which can fail then, one on dm_early_create() and we can easily see that the error path there calls dm_destroy in the error path. The other use case is on the ioctl table_load case. If that fails userspace needs to call the DM_DEV_REMOVE_CMD to cleanup the state - similar to any other failure. Reviewed-by: Hannes Reinecke <hare@...e.de> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org> --- drivers/md/dm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 245fa4153306..6d3265ed37c0 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -2086,7 +2086,9 @@ int dm_setup_md_queue(struct mapped_device *md, struct dm_table *t) if (r) return r; - add_disk(md->disk); + r = add_disk(md->disk); + if (r) + return r; r = dm_sysfs_init(md); if (r) { -- 2.30.2
Powered by blists - more mailing lists