lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Oct 2021 16:52:08 -0700 From: Luis Chamberlain <mcgrof@...nel.org> To: axboe@...nel.dk, geoff@...radead.org, mpe@...erman.id.au, benh@...nel.crashing.org, paulus@...ba.org, jim@...n.com, minchan@...nel.org, ngupta@...are.org, senozhatsky@...omium.org, richard@....at, miquel.raynal@...tlin.com, vigneshr@...com, dan.j.williams@...el.com, vishal.l.verma@...el.com, dave.jiang@...el.com, ira.weiny@...el.com, kbusch@...nel.org, hch@....de, sagi@...mberg.me Cc: linux-block@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-mtd@...ts.infradead.org, nvdimm@...ts.linux.dev, linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org> Subject: [PATCH 02/13] nvme-multipath: add error handling support for add_disk() We never checked for errors on add_disk() as this function returned void. Now that this is fixed, use the shiny new error handling. Since we now can tell for sure when a disk was added, move setting the bit NVME_NSHEAD_DISK_LIVE only when we did add the disk successfully. Nothing to do here as the cleanup is done elsewhere. We take care and use test_and_set_bit() because it is protects against two nvme paths simultaneously calling device_add_disk() on the same namespace head. Signed-off-by: Luis Chamberlain <mcgrof@...nel.org> --- drivers/nvme/host/multipath.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index e8ccdd398f78..022837f7be41 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c @@ -496,13 +496,23 @@ int nvme_mpath_alloc_disk(struct nvme_ctrl *ctrl, struct nvme_ns_head *head) static void nvme_mpath_set_live(struct nvme_ns *ns) { struct nvme_ns_head *head = ns->head; + int rc; if (!head->disk) return; + /* + * test_and_set_bit() is used because it is protecting against two nvme + * paths simultaneously calling device_add_disk() on the same namespace + * head. + */ if (!test_and_set_bit(NVME_NSHEAD_DISK_LIVE, &head->flags)) { - device_add_disk(&head->subsys->dev, head->disk, - nvme_ns_id_attr_groups); + rc = device_add_disk(&head->subsys->dev, head->disk, + nvme_ns_id_attr_groups); + if (rc) { + clear_bit(NVME_NSHEAD_DISK_LIVE, &ns->flags); + return; + } nvme_add_ns_head_cdev(head); } -- 2.30.2
Powered by blists - more mailing lists