linux-kernel - Re: [PATCH] pinctrl: amd: Fix wakeups when IRQ is shared with SCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 16 Oct 2021 01:53:56 +0200
From:   Joerie de Gram <j.de.gram@...il.com>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Basavaraj Natikar <Basavaraj.Natikar@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Nehal Shah <Nehal-bakulchandra.Shah@....com>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH] pinctrl: amd: Fix wakeups when IRQ is shared with SCI

On Fri, Oct 15, 2021 at 09:43:32AM -0500, Mario Limonciello wrote:
> +			if (irq < 0 && !(regval & BIT(WAKE_STS_OFF)))
> +				return true;

Shouldn't be negated. WAKE_STS_OFF is set on wakeup.

With that change:

Reported-by: Joerie de Gram <j.de.gram@...il.com>
Tested-by: Joerie de Gram <j.de.gram@...il.com>