linux-kernel - Re: [PATCH v2 3/4] selftests: nettest: Add --{do,no}-bind-key-ifindex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9c5ce5c-b81e-9dd9-c689-247691fe4249@gmail.com>
Date:   Fri, 15 Oct 2021 08:58:33 +0300
From:   Leonard Crestez <cdleonard@...il.com>
To:     David Ahern <dsahern@...il.com>, David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Kuniyuki Iwashima <kuniyu@...zon.co.jp>,
        Yonghong Song <yhs@...com>,
        Alexander Duyck <alexanderduyck@...com>,
        Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] selftests: nettest: Add --{do,no}-bind-key-ifindex

On 10/14/21 5:25 PM, David Ahern wrote:
> On 10/13/21 12:50 AM, Leonard Crestez wrote:
>> @@ -1856,10 +1870,14 @@ static void print_usage(char *prog)
>>   	"    -n num        number of times to send message\n"
>>   	"\n"
>>   	"    -M password   use MD5 sum protection\n"
>>   	"    -X password   MD5 password for client mode\n"
>>   	"    -m prefix/len prefix and length to use for MD5 key\n"
>> +	"    --no-bind-key-ifindex: Force TCP_MD5SIG_FLAG_IFINDEX off\n"
>> +	"    --do-bind-key-ifindex: Force TCP_MD5SIG_FLAG_IFINDEX on\n"
>> +	"        (default: only if -I is passed)\n"
> 
> a nit:
> just --bind-key-ifindex and --no-bind-key-ifindex
> 
> Reviewed-by: David Ahern <dsahern@...nel.org>

That would be slightly confusing because it would be easy to assume that 
the default behavior is "--bind-key-ifindex".

Instead of using "--do-" as an intensifier I can use "--force-".

--
Regards,
Leonard