linux-kernel - Re: [PATCH] MIPS: Loongson64: Add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H5Uu9REzepwN7BA+g3jgzy-gd263OZjGU2z+b+Eh57bhw@mail.gmail.com>
Date:   Fri, 15 Oct 2021 15:06:39 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Jiaxun Yang <jiaxun.yang@...goat.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "open list:MIPS" <linux-mips@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, kael_w@...h.net
Subject: Re: [PATCH] MIPS: Loongson64: Add of_node_put() before break

Reviewed-by: Huacai Chen <chenhuacai@...nel.org>

On Fri, Oct 15, 2021 at 3:01 PM Wan Jiabing <wanjiabing@...o.com> wrote:
>
> Fix following coccicheck warning:
> ./arch/mips/loongson64/init.c:174:1-22: WARNING: Function
> for_each_node_by_name should have of_node_put() before break
>
> Early exits from for_each_node_by_name should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  arch/mips/loongson64/init.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/loongson64/init.c b/arch/mips/loongson64/init.c
> index 4ac5ba80bbf6..ee8de1735b7c 100644
> --- a/arch/mips/loongson64/init.c
> +++ b/arch/mips/loongson64/init.c
> @@ -179,6 +179,7 @@ static __init void reserve_pio_range(void)
>
>                 if (of_range_parser_init(&parser, np)) {
>                         pr_info("Failed to parse resources.\n");
> +                       of_node_put(np);
>                         break;
>                 }
>
> --
> 2.20.1
>