linux-kernel - Re: [PATCH] staging: vchiq_arm: Add 36-bit address support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211015073042.GP8429@kadam>
Date:   Fri, 15 Oct 2021 10:30:42 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Mwesigwa Guma <mguma@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Ojaswin Mujoo <ojaswin98@...il.com>,
        Amarjargal Gundjalam <amarjargal16@...il.com>,
        Phil Elwell <phil@...pberrypi.com>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev, fedora-rpi@...glegroups.com,
        Joel Savitz <jsavitz@...hat.com>,
        Chukpozohn Toe <ctoe@...hat.com>,
        Clark Williams <clark@...hat.com>
Subject: Re: [PATCH] staging: vchiq_arm: Add 36-bit address support

On Thu, Oct 14, 2021 at 06:32:30PM -0400, Mwesigwa Guma wrote:
> Cc: Nicolas Saenz Julienne <nsaenz@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Stefan Wahren <stefan.wahren@...e.com>
> Cc: Ojaswin Mujoo <ojaswin98@...il.com>
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: Amarjargal Gundjalam <amarjargal16@...il.com>
> Cc: Phil Elwell <phil@...pberrypi.com>
> Cc: bcm-kernel-feedback-list@...adcom.com
> Cc: linux-rpi-kernel@...ts.infradead.org 
> Cc: linux-arm-kernel@...ts.infradead.org 
> Cc: linux-staging@...ts.linux.dev 
> Cc: fedora-rpi@...glegroups.com
> Cc: Joel Savitz <jsavitz@...hat.com>
> Cc: Chukpozohn Toe <ctoe@...hat.com>
> Cc: Clark Williams <clark@...hat.com>
> 

Did you intend to put this CC list here?  It goes at the end next to
the Signed-off-by line if so.  I don't feel like it's required except
maybe Phil to show he was Cc'd.

> This is a forward port of Phil Elwell's commit from the Raspberry Pi
> Linux fork described as follows [1]:

Please use the From: header to give authorship credit.

From: Phil Elwell <phil@...pberrypi.com>

Make that the first line of the email.

> 
>     Conditional on a new compatible string, change the pagelist encoding
>     such that the top 24 bits are the pfn, leaving 8 bits for run length
>     (-1), giving a 36-bit address range.
>     
>     Manage the split between addresses for the VPU and addresses for the
>     40-bit DMA controller with a dedicated DMA device pointer that on non-
>     BCM2711 platforms is the same as the main VCHIQ device. This allows
>     the VCHIQ node to stay in the usual place in the DT.
> 
> This commit enables VCHIQ device access on a Raspberry Pi 4B running the 
> mainline Linux kernel.
> 
> Tested on Fedora Linux running on a Raspberry Pi 4B.
> 
> [1]: https://github.com/raspberrypi/linux/commit/97268fd23eb8d08dc74eac5e3fd697303de26610
> 
> Signed-off-by: Mwesigwa Guma <mguma@...hat.com>

regards,
dan carpenter