linux-kernel - Re: [PATCH v2 05/13] net: phy: add qca8081 ethernet phy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWkzxd7xzTDngoT9@shell.armlinux.org.uk>
Date:   Fri, 15 Oct 2021 08:54:45 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Luo Jie <luoj@...eaurora.org>
Cc:     andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, sricharan@...eaurora.org
Subject: Re: [PATCH v2 05/13] net: phy: add qca8081 ethernet phy driver

On Fri, Oct 15, 2021 at 03:34:57PM +0800, Luo Jie wrote:
> @@ -1431,6 +1433,18 @@ static struct phy_driver at803x_driver[] = {
>  	.get_sset_count = at803x_get_sset_count,
>  	.get_strings = at803x_get_strings,
>  	.get_stats = at803x_get_stats,
> +}, {
> +	/* Qualcomm QCA8081 */
> +	PHY_ID_MATCH_EXACT(QCA8081_PHY_ID),
> +	.name			= "Qualcomm QCA8081 PHY",

I don't think we need the " PHY" suffix. This name gets printed in a
context where it's obvious it's a network PHY.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!