lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Fri, 15 Oct 2021 10:04:58 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     changlianzhi <changlianzhi@...ontech.com>
Cc:     linux-kernel@...r.kernel.org, dmitry.torokhov@...il.com,
        jirislaby@...nel.org, andriy.shevchenko@...ux.intel.com,
        linux-input@...r.kernel.org, 282827961@...com
Subject: Re: [PATCH] input&tty: Fix the keyboard led light display problem

On Fri, Oct 15, 2021 at 03:59:38PM +0800, changlianzhi wrote:
> 
> On 2021/10/15 下午2:52, Greg KH wrote:
> > On Fri, Oct 15, 2021 at 02:45:34PM +0800, lianzhi chang wrote:
> > > Switching from the desktop environment to the tty environment,
> > > the state of the keyboard led lights and the state of the keyboard
> > > lock are inconsistent. This is because the attribute kb->kbdmode
> > > of the tty bound in the desktop environment (xorg) is set to
> > > VC_OFF, which causes the ledstate and kb->ledflagstate
> > > values of the bound tty to always be 0, which causes the switch
> > > from the desktop When to the tty environment, the LED light
> > > status is inconsistent with the keyboard lock status.
> > > 
> > > Signed-off-by: lianzhi chang <changlianzhi@...ontech.com>
> > > ---
> > >   drivers/input/input.c     | 46 ++++++++++++++++++++++++++++++++++++++-
> > >   drivers/tty/vt/keyboard.c | 19 ++++++++++++++--
> > >   include/linux/input.h     |  3 +++
> > >   3 files changed, 65 insertions(+), 3 deletions(-)
> > Hi,
> > 
> > This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> > a patch that has triggered this response.  He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
> > writing the same thing over and over, yet to different people), I was
> > created.  Hopefully you will not take offence and will fix the problem
> > in your patch and resubmit it so that it can be accepted into the Linux
> > kernel tree.
> > 
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> > 
> > - This looks like a new version of a previously submitted patch, but you
> >    did not list below the --- line any changes from the previous version.
> >    Please read the section entitled "The canonical patch format" in the
> >    kernel file, Documentation/SubmittingPatches for what needs to be done
> >    here to properly describe this.
> > 
> > If you wish to discuss this problem further, or you have questions about
> > how to resolve this issue, please feel free to respond to this email and
> > Greg will reply once he has dug out from the pending patches received
> > from other developers.
> > 
> > thanks,
> > 
> > greg k-h's patch email bot
> > 
> 
> >>The latest changes:
> >>(1) Move the definition of ledstate to the input module
> (/drivers/input/input.c), and set or get its value through the
> input_update_ledstate and input_get_ledstate functions.
> >>(2) To update the ledstate reference in keyboard.c, you must first get the
> value through input_get_ledstate.
> >>(3) Other necessary changes

I do not want to see this here, it needs to go into the patch you submit
as the documentation says to.  Read the link that the bot pointed you at
above please...

Powered by blists - more mailing lists