linux-kernel - Re: [PATCH] eeprom: 93xx46: fix MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Oct 2021 10:54:00 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Mark Brown <broonie@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Aswath Govindraju <a-govindraju@...com>,
        Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eeprom: 93xx46: fix MODULE_DEVICE_TABLE

On Thu, Oct 14, 2021 at 05:37:18PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The newly added SPI device ID table does not work because the
> entry is incorrectly copied from the OF device table.
> 
> During build testing, this shows as a compile failure when building
> it as a loadable module:
> 
> drivers/misc/eeprom/eeprom_93xx46.c:424:1: error: redefinition of '__mod_of__eeprom_93xx46_of_table_device_table'
> MODULE_DEVICE_TABLE(of, eeprom_93xx46_of_table);
> 
> Change the entry to refer to the correct symbol.
> 
> Fixes: 137879f7ff23 ("eeprom: 93xx46: Add SPI device ID table")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/misc/eeprom/eeprom_93xx46.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ah, nice catch, will queue this up now, thanks!

greg k-h