lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20211015103155.949385-1-miquel.raynal@bootlin.com> Date: Fri, 15 Oct 2021 12:31:55 +0200 From: Miquel Raynal <miquel.raynal@...tlin.com> To: Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, Tudor Ambarus <Tudor.Ambarus@...rochip.com> Cc: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org, Jan Hoffmann <jan@....eu>, Kestrel seventyfour <kestrelseventyfour@...il.com> Subject: Re: [PATCH 9/9] mtd: rawnand: xway: Keep the driver compatible with on-die ECC engines On Tue, 2021-09-28 at 22:22:48 UTC, Miquel Raynal wrote: > Following the introduction of the generic ECC engine infrastructure, it > was necessary to reorganize the code and move the ECC configuration in > the ->attach_chip() hook. Failing to do that properly lead to a first > series of fixes supposed to stabilize the situation. Unfortunately, this > only fixed the use of software ECC engines, preventing any other kind of > engine to be used, including on-die ones. > > It is now time to (finally) fix the situation by ensuring that we still > provide a default (eg. software ECC) but will still support different > ECC engines such as on-die ECC engines if properly described in the > device tree. > > There are no changes needed on the core side in order to do this, but we > just need to leverage the logic there which allows: > 1- a subsystem default (set to Host engines in the raw NAND world) > 2- a driver specific default (here set to software ECC engines) > 3- any type of engine requested by the user (ie. described in the DT) > > As the raw NAND subsystem has not yet been fully converted to the ECC > engine infrastructure, in order to provide a default ECC engine for this > driver we need to set chip->ecc.engine_type *before* calling > nand_scan(). During the initialization step, the core will consider this > entry as the default engine for this driver. This value may of course > be overloaded by the user if the usual DT properties are provided. > > Fixes: d525914b5bd8 ("mtd: rawnand: xway: Move the ECC initialization to ->attach_chip()") > Cc: stable@...r.kernel.org > Cc: Jan Hoffmann <jan@....eu> > Cc: Kestrel seventyfour <kestrelseventyfour@...il.com> > Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com> > Tested-by: Jan Hoffmann <jan@....eu> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next. Miquel
Powered by blists - more mailing lists