linux-kernel - Re: [PATCH] media: drivers: cx24113: remove redundant variable r

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <163429568660.4164224.1248800864545725818@Monstersaurus>
Date:   Fri, 15 Oct 2021 12:01:26 +0100
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Colin King <colin.king@...onical.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: drivers: cx24113: remove redundant variable r

Quoting Colin King (2021-10-14 16:12:35)
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable r is being assigned values but it is never being
> used. The variable is redundant and can be removed.
> 

Indeed, it gets re-assigned at line 385 as the first cx24113_readreg.


Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/media/dvb-frontends/cx24113.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/cx24113.c b/drivers/media/dvb-frontends/cx24113.c
> index 60a9f70275f7..dd55d314bf9a 100644
> --- a/drivers/media/dvb-frontends/cx24113.c
> +++ b/drivers/media/dvb-frontends/cx24113.c
> @@ -378,7 +378,7 @@ static void cx24113_set_nfr(struct cx24113_state *state, u16 n, s32 f, u8 r)
>  
>  static int cx24113_set_frequency(struct cx24113_state *state, u32 frequency)
>  {
> -       u8 r = 1; /* or 2 */
> +       u8 r;
>         u16 n = 6;
>         s32 f = 0;
>  
> -- 
> 2.32.0
>