lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Oct 2021 12:12:20 +0100 From: Kieran Bingham <kieran.bingham@...asonboard.com> To: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>, Mauro Carvalho Chehab <mchehab@...nel.org>, Rikard Falkeborn <rikard.falkeborn@...il.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, Rikard Falkeborn <rikard.falkeborn@...il.com> Subject: Re: [PATCH] staging: media: rkvdec: Constify static struct v4l2_m2m_ops Quoting Rikard Falkeborn (2021-10-12 23:11:44) > The only usage of rkvdec_m2m_ops is to pass its address to v4l2_m2m_init(), > which takes a pointer to const v4l2_m2m_ops as argument. Make it const > to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com> > --- > drivers/staging/media/rkvdec/rkvdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c > index bf00fe6534a3..28aab5c7fe33 100644 > --- a/drivers/staging/media/rkvdec/rkvdec.c > +++ b/drivers/staging/media/rkvdec/rkvdec.c > @@ -677,7 +677,7 @@ static void rkvdec_device_run(void *priv) > rkvdec_job_finish(ctx, VB2_BUF_STATE_ERROR); > } > > -static struct v4l2_m2m_ops rkvdec_m2m_ops = { > +static const struct v4l2_m2m_ops rkvdec_m2m_ops = { > .device_run = rkvdec_device_run, > }; > > -- > 2.33.0 >
Powered by blists - more mailing lists