linux-kernel - Re: [PATCH] usb: dwc3: gadget: Remove dev_err() when queuing to inactive gadget/ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bl3qbkfz.fsf@kernel.org>
Date:   Fri, 15 Oct 2021 14:23:13 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Wesley Cheng <wcheng@...eaurora.org>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, jackp@...eaurora.org
Subject: Re: [PATCH] usb: dwc3: gadget: Remove dev_err() when queuing to
 inactive gadget/ep


Greg KH <gregkh@...uxfoundation.org> writes:

> On Thu, Oct 14, 2021 at 04:35:34PM -0700, Wesley Cheng wrote:
>> Since function drivers will still be active until dwc3_disconnect_gadget()
>> is called, some applications will continue to queue packets to DWC3
>> gadget.  This can lead to a flood of messages regarding failed ep queue,
>> as the endpoint is in the process of being disabled.  Remove the print as
>> function drivers will likely log queuing errors as well.
>> 
>> Signed-off-by: Wesley Cheng <wcheng@...eaurora.org>
>> ---
>>  drivers/usb/dwc3/gadget.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>> 
>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
>> index 4845682a0408..674a9a527125 100644
>> --- a/drivers/usb/dwc3/gadget.c
>> +++ b/drivers/usb/dwc3/gadget.c
>> @@ -1812,11 +1812,8 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *dep, struct dwc3_request *req)
>>  {
>>  	struct dwc3		*dwc = dep->dwc;
>>  
>> -	if (!dep->endpoint.desc || !dwc->pullups_connected || !dwc->connected) {
>> -		dev_err(dwc->dev, "%s: can't queue to disabled endpoint\n",
>> -				dep->name);
>
> Why not just change this to dev_dbg() instead?

I agree. A dev_dbg() would be better here. We don't want to loose this
message forever as it may prevent us from finding buggy function
drivers.

-- 
balbi