linux-kernel - [PATCH] hwmon: (ad7414) cleanup codestyle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211015122843.135814-1-sohaib.amhmd@gmail.com>
Date:   Fri, 15 Oct 2021 14:28:43 +0200
From:   Sohaib Mohamed <sohaib.amhmd@...il.com>
To:     sohaib.amhmd@...il.com
Cc:     Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] hwmon: (ad7414) cleanup codestyle

- Add a blank line after declarations
- Prefer using '"%s...", __func__' to using 'ad7414_probe'
- Don't split strings across lines

Signed-off-by: Sohaib Mohamed <sohaib.amhmd@...il.com>
---
 drivers/hwmon/ad7414.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/hwmon/ad7414.c b/drivers/hwmon/ad7414.c
index 0afb89c4629d..52df6005812c 100644
--- a/drivers/hwmon/ad7414.c
+++ b/drivers/hwmon/ad7414.c
@@ -107,6 +107,7 @@ static ssize_t temp_input_show(struct device *dev,
 			       struct device_attribute *attr, char *buf)
 {
 	struct ad7414_data *data = ad7414_update_device(dev);
+
 	return sprintf(buf, "%d\n", ad7414_temp_from_reg(data->temp_input));
 }
 static SENSOR_DEVICE_ATTR_RO(temp1_input, temp_input, 0);
@@ -116,6 +117,7 @@ static ssize_t max_min_show(struct device *dev, struct device_attribute *attr,
 {
 	int index = to_sensor_dev_attr(attr)->index;
 	struct ad7414_data *data = ad7414_update_device(dev);
+
 	return sprintf(buf, "%d\n", data->temps[index] * 1000);
 }
 
@@ -152,6 +154,7 @@ static ssize_t alarm_show(struct device *dev, struct device_attribute *attr,
 	int bitnr = to_sensor_dev_attr(attr)->index;
 	struct ad7414_data *data = ad7414_update_device(dev);
 	int value = (data->temp_input >> bitnr) & 1;
+
 	return sprintf(buf, "%d\n", value);
 }
 
@@ -192,7 +195,7 @@ static int ad7414_probe(struct i2c_client *client)
 	/* Make sure the chip is powered up. */
 	conf = i2c_smbus_read_byte_data(client, AD7414_REG_CONF);
 	if (conf < 0)
-		dev_warn(dev, "ad7414_probe unable to read config register.\n");
+		dev_warn(dev, "%s unable to read config register.\n", __func__);
 	else {
 		conf &= ~(1 << 7);
 		i2c_smbus_write_byte_data(client, AD7414_REG_CONF, conf);
@@ -227,8 +230,7 @@ static struct i2c_driver ad7414_driver = {
 
 module_i2c_driver(ad7414_driver);
 
-MODULE_AUTHOR("Stefan Roese <sr at denx.de>, "
-	      "Frank Edelhaeuser <frank.edelhaeuser at spansion.com>");
+MODULE_AUTHOR("Stefan Roese <sr at denx.de>, Frank Edelhaeuser <frank.edelhaeuser at spansion.com>");
 
 MODULE_DESCRIPTION("AD7414 driver");
 MODULE_LICENSE("GPL");
-- 
2.25.1