linux-kernel - Re: [PATCH] ARM: dts: stm32: fix SAI sub nodes register range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2c206ad-503b-3652-8741-d4c660b8dedf@foss.st.com>
Date:   Fri, 15 Oct 2021 15:01:57 +0200
From:   Alexandre TORGUE <alexandre.torgue@...s.st.com>
To:     Olivier Moysan <olivier.moysan@...s.st.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Olivier Moysan <olivier.moysan@...com>,
        "Rob Herring" <robh+dt@...nel.org>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH] ARM: dts: stm32: fix SAI sub nodes register range

On 9/24/21 6:02 PM, Olivier Moysan wrote:
> The STM32 SAI subblocks registers offsets are in the range
> 0x0004 (SAIx_CR1) to 0x0020 (SAIx_DR).
> The corresponding range length is 0x20 instead of 0x1c.
> Change reg property accordingly.
> 
> Fixes: 5afd65c3a060 ("ARM: dts: stm32: add sai support on stm32mp157c")
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@...s.st.com>
> ---
>   arch/arm/boot/dts/stm32mp151.dtsi | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
> index bd289bf5d269..6992a4b0ba79 100644
> --- a/arch/arm/boot/dts/stm32mp151.dtsi
> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
> @@ -824,7 +824,7 @@
>   				#sound-dai-cells = <0>;
>   
>   				compatible = "st,stm32-sai-sub-a";
> -				reg = <0x4 0x1c>;
> +				reg = <0x4 0x20>;
>   				clocks = <&rcc SAI1_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 87 0x400 0x01>;
> @@ -834,7 +834,7 @@
>   			sai1b: audio-controller@...0a024 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-b";
> -				reg = <0x24 0x1c>;
> +				reg = <0x24 0x20>;
>   				clocks = <&rcc SAI1_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 88 0x400 0x01>;
> @@ -855,7 +855,7 @@
>   			sai2a: audio-controller@...0b004 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-a";
> -				reg = <0x4 0x1c>;
> +				reg = <0x4 0x20>;
>   				clocks = <&rcc SAI2_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 89 0x400 0x01>;
> @@ -865,7 +865,7 @@
>   			sai2b: audio-controller@...0b024 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-b";
> -				reg = <0x24 0x1c>;
> +				reg = <0x24 0x20>;
>   				clocks = <&rcc SAI2_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 90 0x400 0x01>;
> @@ -886,7 +886,7 @@
>   			sai3a: audio-controller@...0c004 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-a";
> -				reg = <0x04 0x1c>;
> +				reg = <0x04 0x20>;
>   				clocks = <&rcc SAI3_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 113 0x400 0x01>;
> @@ -896,7 +896,7 @@
>   			sai3b: audio-controller@...0c024 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-b";
> -				reg = <0x24 0x1c>;
> +				reg = <0x24 0x20>;
>   				clocks = <&rcc SAI3_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 114 0x400 0x01>;
> @@ -1271,7 +1271,7 @@
>   			sai4a: audio-controller@...27004 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-a";
> -				reg = <0x04 0x1c>;
> +				reg = <0x04 0x20>;
>   				clocks = <&rcc SAI4_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 99 0x400 0x01>;
> @@ -1281,7 +1281,7 @@
>   			sai4b: audio-controller@...27024 {
>   				#sound-dai-cells = <0>;
>   				compatible = "st,stm32-sai-sub-b";
> -				reg = <0x24 0x1c>;
> +				reg = <0x24 0x20>;
>   				clocks = <&rcc SAI4_K>;
>   				clock-names = "sai_ck";
>   				dmas = <&dmamux1 100 0x400 0x01>;
> 

Applied on stm32-next.

Thanks
Alex