linux-kernel - Re: [PATCH -next] drm/v3d: nullify pointer se with a NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211015134631.l76ai6mdxzrflnv6@mail.igalia.com>
Date:   Fri, 15 Oct 2021 14:46:59 +0100
From:   Melissa Wen <mwen@...lia.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     airlied@...ux.ie, daniel@...ll.ch, emma@...olt.net,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/v3d: nullify pointer se with a NULL

On 10/15, Yang Li wrote:
> Currently a plain integer is being used to nullify the pointer
> struct v3d_submit_ext *se. Use NULL instead. Cleans up sparse
> warnings:
> drivers/gpu/drm/v3d/v3d_gem.c:777:53: warning: Using plain integer as
> NULL pointer
> drivers/gpu/drm/v3d/v3d_gem.c:1010:45: warning: Using plain integer as
> NULL pointer
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/gpu/drm/v3d/v3d_gem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
> index e47ae40..c7ed2e1 100644
> --- a/drivers/gpu/drm/v3d/v3d_gem.c
> +++ b/drivers/gpu/drm/v3d/v3d_gem.c
> @@ -774,7 +774,7 @@ void v3d_job_put(struct v3d_job *job)
>  
>  	if (args->flags & DRM_V3D_SUBMIT_CL_FLUSH_CACHE) {
>  		ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
> -				   v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
> +				   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
>  		if (ret)
>  			goto fail;
>  
> @@ -1007,7 +1007,7 @@ void v3d_job_put(struct v3d_job *job)
>  		goto fail;
>  
>  	ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
> -			   v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
> +			   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
>  	if (ret)
>  		goto fail;

Thanks, 

Reviewed-by: Melissa Wen <mwen@...lia.com>

and I'll apply do drm-misc-next.
>  
> -- 
> 1.8.3.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)