| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202110152133.QORVBjDX-lkp@intel.com>
Date: Fri, 15 Oct 2021 21:50:50 +0800
From: kernel test robot <lkp@...el.com>
To: Zqiang <qiang.zhang1211@...il.com>, willy@...radead.org,
hch@...radead.org, akpm@...ux-foundation.org, sunhao.th@...il.com
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
Zqiang <qiang.zhang1211@...il.com>
Subject: Re: [PATCH] fs: inode: use queue_rcu_work() instead of call_rcu()
Hi Zqiang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.15-rc5 next-20211015]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zqiang/fs-inode-use-queue_rcu_work-instead-of-call_rcu/20211015-160455
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git ec681c53f8d2d0ee362ff67f5b98dd8263c15002
config: hexagon-randconfig-r041-20211014 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project acb3b187c4c88650a6a717a1bcb234d27d0d7f54)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2294caaec521b45bdc9db96423fe51762e47afd0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zqiang/fs-inode-use-queue_rcu_work-instead-of-call_rcu/20211015-160455
git checkout 2294caaec521b45bdc9db96423fe51762e47afd0
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/ntfs3/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> fs/ntfs3/super.c:458:57: error: no member named 'i_rcu' in 'struct inode'
struct inode *inode = container_of(head, struct inode, i_rcu);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
include/linux/kernel.h:495:53: note: expanded from macro 'container_of'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
include/linux/compiler_types.h:264:74: note: expanded from macro '__same_type'
#define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
^
include/linux/build_bug.h:39:58: note: expanded from macro 'BUILD_BUG_ON_MSG'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
include/linux/compiler_types.h:322:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:310:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:302:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
>> fs/ntfs3/super.c:458:24: error: no member named 'i_rcu' in 'inode'
struct inode *inode = container_of(head, struct inode, i_rcu);
^ ~~~~~
include/linux/kernel.h:498:21: note: expanded from macro 'container_of'
((type *)(__mptr - offsetof(type, member))); })
^ ~~~~~~
include/linux/stddef.h:17:32: note: expanded from macro 'offsetof'
#define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
^ ~~~~~~
include/linux/compiler_types.h:140:35: note: expanded from macro '__compiler_offsetof'
#define __compiler_offsetof(a, b) __builtin_offsetof(a, b)
^ ~
>> fs/ntfs3/super.c:458:16: error: initializing 'struct inode *' with an expression of incompatible type 'void'
struct inode *inode = container_of(head, struct inode, i_rcu);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/ntfs3/super.c:468:19: error: no member named 'i_rcu' in 'struct inode'
call_rcu(&inode->i_rcu, ntfs_i_callback);
~~~~~ ^
4 errors generated.
vim +458 fs/ntfs3/super.c
82cae269cfa953 Konstantin Komarov 2021-08-13 455
82cae269cfa953 Konstantin Komarov 2021-08-13 456 static void ntfs_i_callback(struct rcu_head *head)
82cae269cfa953 Konstantin Komarov 2021-08-13 457 {
82cae269cfa953 Konstantin Komarov 2021-08-13 @458 struct inode *inode = container_of(head, struct inode, i_rcu);
82cae269cfa953 Konstantin Komarov 2021-08-13 459 struct ntfs_inode *ni = ntfs_i(inode);
82cae269cfa953 Konstantin Komarov 2021-08-13 460
82cae269cfa953 Konstantin Komarov 2021-08-13 461 mutex_destroy(&ni->ni_lock);
82cae269cfa953 Konstantin Komarov 2021-08-13 462
82cae269cfa953 Konstantin Komarov 2021-08-13 463 kmem_cache_free(ntfs_inode_cachep, ni);
82cae269cfa953 Konstantin Komarov 2021-08-13 464 }
82cae269cfa953 Konstantin Komarov 2021-08-13 465
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (40599 bytes)
Powered by blists - more mailing lists