linux-kernel - Re: [PATCH v6 26/48] mfd: ti_am335x_tscadc: Drop unused definitions from the header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211015150049.0000673b@Huawei.com>
Date:   Fri, 15 Oct 2021 15:00:49 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Lee Jones <lee.jones@...aro.org>, <linux-iio@...r.kernel.org>,
        <linux-omap@...r.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Ryan Barnett <ryan.barnett@...lins.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 26/48] mfd: ti_am335x_tscadc: Drop unused definitions
 from the header

On Fri, 15 Oct 2021 10:14:44 +0200
Miquel Raynal <miquel.raynal@...tlin.com> wrote:

> The STEP ENABLE definitions are highly unclear and not used so drop them.
> 
> Suggested-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

Thanks for tidying that up.

> ---
>  include/linux/mfd/ti_am335x_tscadc.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h
> index a85643677bef..1cd8cd34f2b7 100644
> --- a/include/linux/mfd/ti_am335x_tscadc.h
> +++ b/include/linux/mfd/ti_am335x_tscadc.h
> @@ -39,13 +39,6 @@
>  /* IRQ wakeup enable */
>  #define IRQWKUP_ENB		BIT(0)
>  
> -/* Step Enable */
> -#define STEPENB_MASK		(0x1FFFF << 0)
> -#define STEPENB(val)		((val) << 0)
> -#define ENB(val)		(1 << (val))
> -#define STPENB_STEPENB		STEPENB(0x1FFFF)
> -#define STPENB_STEPENB_TC	STEPENB(0x1FFF)
> -
>  /* IRQ enable */
>  #define IRQENB_HW_PEN		BIT(0)
>  #define IRQENB_EOS		BIT(1)