lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 15 Oct 2021 20:20:23 +0300
From:   Andy Shevchenko <>
To:     Mauri Sandberg <>
Cc:     Mauri Sandberg <>,
        Bartosz Golaszewski <>,
        Geert Uytterhoeven <>,
        Linus Walleij <>,
        "open list:GPIO SUBSYSTEM" <>,
        Rob Herring <>,
        devicetree <>,
        Linux Kernel Mailing List <>,
        Drew Fustini <>
Subject: Re: [PATCH v5 2/2] gpio: gpio-cascade: add generic GPIO cascade

On Fri, Oct 15, 2021 at 3:56 PM Mauri Sandberg <> wrote:
> On 21.6.2021 20.43, Andy Shevchenko wrote:
> >> +       gc->of_node = np;
> >
> > This should be guarded by CONFIG_OF_GPIO.

The above is actually done by the GPIO library nowadays.

> In the Kconfig I have a dependency to OF_GPIO. Is the guarding still
> necessary? Or should the guard be added and dependency removed? Or have
> them both?

For this kind ("generic") driver the OF_GPIO dependency is simply
wrong. You shouldn't have it.

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists