linux-kernel - Re: [PATCH v2 0/2] Apple Mailbox Controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <94e07975-f63e-4568-986f-71a278777e9d@www.fastmail.com>
Date:   Sat, 16 Oct 2021 11:21:16 +0200
From:   "Sven Peter" <sven@...npeter.dev>
To:     "Jassi Brar" <jassisinghbrar@...il.com>
Cc:     "Rob Herring" <robh+dt@...nel.org>,
        "Mark Kettenis" <mark.kettenis@...all.nl>,
        "Hector Martin" <marcan@...can.st>,
        "Alyssa Rosenzweig" <alyssa@...enzweig.io>,
        "Mohamed Mediouni" <mohamed.mediouni@...amail.com>,
        "Stan Skowronek" <stan@...ellium.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] Apple Mailbox Controller support

On Thu, Sep 16, 2021, at 17:49, Sven Peter wrote:
> Hi,
>
> This is the second version of my series which adds support for the mailbox
> controllers found on the Apple M1.
>
> v1: https://lore.kernel.org/lkml/20210907145501.69161-1-sven@svenpeter.dev/
>
> Thanks to Jassi, Mark and Alyssa for the initial review. I've addressed
> your comments with the following changes:
>
>  - switched to txdone_irq instead of introducing a new mode
>  - switched to a threaded interrupt handler for receiving messages
>  - added co-processor examples to the device tree binding 
>  - reformatted the register defines and clarified multiple comments
>
> Best,
>
> Sven
>
> Sven Peter (2):
>   dt-bindings: mailbox: Add Apple mailbox bindings
>   mailbox: apple: Add driver for Apple mailboxes
>
>  .../bindings/mailbox/apple,mailbox.yaml       |  84 ++++
>  MAINTAINERS                                   |   3 +
>  drivers/mailbox/Kconfig                       |  12 +
>  drivers/mailbox/Makefile                      |   2 +
>  drivers/mailbox/apple-mailbox.c               | 431 ++++++++++++++++++
>  include/linux/apple-mailbox.h                 |  18 +
>  6 files changed, 550 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
>  create mode 100644 drivers/mailbox/apple-mailbox.c
>  create mode 100644 include/linux/apple-mailbox.h
>
> -- 
> 2.25.1

Hi Jassi,

Have you had a chance to look at this series yet?


Thanks,


Sven