linux-kernel - Re: [PATCH 6/7] staging: r8188eu: pMacPhyMode is not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 16 Oct 2021 11:45:58 +0200
From:   Martin Kaiser <lists@...ser.cx>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] staging: r8188eu: pMacPhyMode is not used

Thus wrote Michael Straube (straube.linux@...il.com):

> pMacPhyMode is not used. Remove it from odm_dm_struct and remove
> related dead code.

> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
>  drivers/staging/r8188eu/hal/odm.c     | 3 ---
>  drivers/staging/r8188eu/include/odm.h | 3 ---
>  2 files changed, 6 deletions(-)

> diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
> index 85bc5050cda5..a2cbe727f6e0 100644
> --- a/drivers/staging/r8188eu/hal/odm.c
> +++ b/drivers/staging/r8188eu/hal/odm.c
> @@ -231,9 +231,6 @@ void ODM_CmnInfoHook(struct odm_dm_struct *pDM_Odm, enum odm_common_info_def Cmn
>  	/*  */
>  	switch	(CmnInfo) {
>  	/*  Dynamic call by reference pointer. */
> -	case	ODM_CMNINFO_MAC_PHY_MODE:
> -		pDM_Odm->pMacPhyMode = (u8 *)pValue;
> -		break;
>  	case	ODM_CMNINFO_TX_UNI:
>  		pDM_Odm->pNumTxBytesUnicast = (u64 *)pValue;
>  		break;
> diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
> index 9745069060d7..6cbf64df9be7 100644
> --- a/drivers/staging/r8188eu/include/odm.h
> +++ b/drivers/staging/r8188eu/include/odm.h
> @@ -269,7 +269,6 @@ enum odm_common_info_def {

>  	/*  Dynamic value: */
>  /*  POINTER REFERENCE-----------  */
> -	ODM_CMNINFO_MAC_PHY_MODE,	/*  ODM_MAC_PHY_MODE_E */
>  	ODM_CMNINFO_TX_UNI,
>  	ODM_CMNINFO_RX_UNI,
>  	ODM_CMNINFO_WM_MODE,		/*  ODM_WIRELESS_MODE_E */
> @@ -621,8 +620,6 @@ struct odm_dm_struct {
>  	bool	bool_temp;
>  	struct adapter *adapter_temp;

> -	/*  MAC PHY Mode SMSP/DMSP/DMDP = 0/1/2 */
> -	u8	*pMacPhyMode;
>  	/* TX Unicast byte count */
>  	u64	*pNumTxBytesUnicast;
>  	/* RX Unicast byte count */
> -- 
> 2.33.0

Acked-by: Martin Kaiser <martin@...ser.cx>