linux-kernel - Re: [PATCH] memory: mtk-smi: Use ARRAY_SIZE to define MTK_SMI_CLK_NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e411c148ac44d5d970b6fba8861f63434f83ec5.camel@mediatek.com>
Date:   Sat, 16 Oct 2021 10:13:21 +0800
From:   Yong Wu <yong.wu@...iatek.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        <krzysztof.kozlowski@...onical.com>
CC:     <matthias.bgg@...il.com>, <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] memory: mtk-smi: Use ARRAY_SIZE to define
 MTK_SMI_CLK_NR_MAX

On Fri, 2021-10-15 at 17:15 +0200, AngeloGioacchino Del Regno wrote:
> This definition is tied to the number of SMI common clocks (the array
> mtk_smi_common_clks): improve the definition by using the ARRAY_SIZE
> macro instead. That will also reduce room for mistakes when updating
> the aforementioned array in the future.
> 
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>

Reviewed-by: Yong Wu <yong.wu@...iatek.com>

Thanks for this patch.

> ---
>  drivers/memory/mtk-smi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> index b883dcc0bbfa..6331422141e8 100644
> --- a/drivers/memory/mtk-smi.c
> +++ b/drivers/memory/mtk-smi.c
> @@ -94,8 +94,6 @@ enum mtk_smi_type {
>  	MTK_SMI_GEN2_SUB_COMM,	/* gen2 smi sub common */
>  };
>  
> -#define MTK_SMI_CLK_NR_MAX			4
> -
>  /* larbs: Require apb/smi clocks while gals is optional. */
>  static const char * const mtk_smi_larb_clks[] = {"apb", "smi",
> "gals"};
>  #define MTK_SMI_LARB_REQ_CLK_NR		2
> @@ -106,6 +104,7 @@ static const char * const mtk_smi_larb_clks[] =
> {"apb", "smi", "gals"};
>   * sub common: Require apb/smi/gals0 clocks in has_gals case.
> Otherwise, only apb/smi are required.
>   */
>  static const char * const mtk_smi_common_clks[] = {"apb", "smi",
> "gals0", "gals1"};
> +#define MTK_SMI_CLK_NR_MAX		ARRAY_SIZE(mtk_smi_common_clks)
>  #define MTK_SMI_COM_REQ_CLK_NR		2
>  #define MTK_SMI_COM_GALS_REQ_CLK_NR	MTK_SMI_CLK_NR_MAX
>  #define MTK_SMI_SUB_COM_GALS_REQ_CLK_NR 3