linux-kernel - Re: [PATCH net] net: dsa: lantiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0abd339a-3a9b-edfc-d697-27fce492bdd0@hauke-m.de>
Date:   Sat, 16 Oct 2021 13:57:59 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     Aleksander Jan Bajkowski <olek2@...pl>, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: lantiq_gswip: fix register definition

On 10/16/21 12:10 AM, Aleksander Jan Bajkowski wrote:
> I compared the register definitions with the D-Link DWR-966
> GPL sources and found that the PUAFD field definition was
> incorrect. This definition is unused and causes no issues.
> 
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@...pl>

Acked-by: Hauke Mehrtens <hauke@...ke-m.de>

Thanks for finding this problem.

> ---
>   drivers/net/dsa/lantiq_gswip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index 3ff4b7e177f3..dbd4486a173f 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -230,7 +230,7 @@
>   #define GSWIP_SDMA_PCTRLp(p)		(0xBC0 + ((p) * 0x6))
>   #define  GSWIP_SDMA_PCTRL_EN		BIT(0)	/* SDMA Port Enable */
>   #define  GSWIP_SDMA_PCTRL_FCEN		BIT(1)	/* Flow Control Enable */
> -#define  GSWIP_SDMA_PCTRL_PAUFWD	BIT(1)	/* Pause Frame Forwarding */
> +#define  GSWIP_SDMA_PCTRL_PAUFWD	BIT(3)	/* Pause Frame Forwarding */
>   
>   #define GSWIP_TABLE_ACTIVE_VLAN		0x01
>   #define GSWIP_TABLE_VLAN_MAPPING	0x02
>