linux-kernel - Re: [PATCH 7/8] arm64: dts: qcom: msm8996: Add MSM8996 Pro support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZVR21R.X63CT137R99A3@protonmail.com>
Date:   Sat, 16 Oct 2021 14:50:54 +0000
From:   Yassine Oudjana <y.oudjana@...tonmail.com>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Ilia Lin <ilia.lin@...nel.org>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Loic Poulain <loic.poulain@...aro.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
        phone-devel@...r.kernel.org
Subject: Re: [PATCH 7/8] arm64: dts: qcom: msm8996: Add MSM8996 Pro support


On Fri, Oct 15 2021 at 23:01:54 +0400, Konrad Dybcio 
<konrad.dybcio@...ainline.org> wrote:
> 
> On 14.10.2021 10:32, Yassine Oudjana wrote:
>>  Add a new DTSI for MSM8996 Pro (MSM8996SG) with msm-id and CPU/GPU 
>> OPPs.
>>  CBF OPPs and CPR parameters will be added to it as well once 
>> support for
>>  CBF scaling and CPR is introduced.
>> 
>>  Signed-off-by: Yassine Oudjana <y.oudjana@...tonmail.com>
>>  ---
>>   arch/arm64/boot/dts/qcom/msm8996.dtsi    |  82 +++----
>>   arch/arm64/boot/dts/qcom/msm8996pro.dtsi | 281 
>> +++++++++++++++++++++++
>>   2 files changed, 322 insertions(+), 41 deletions(-)
>>   create mode 100644 arch/arm64/boot/dts/qcom/msm8996pro.dtsi
>> 
>>  diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi 
>> b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>  index 94a846c3f1ee..5b2600a4fb2a 100644
>>  --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>  +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>  @@ -142,82 +142,82 @@ cluster0_opp: opp_table0 {
>>   		/* Nominal fmax for now */
>>   		opp-307200000 {
>>   			opp-hz = /bits/ 64 <307200000>;
>>  -			opp-supported-hw = <0x77>;
>>  +			opp-supported-hw = <0x7>;
> 
> You didn't describe what's the reason for changing this everywhere.
> 
> If it's been always broken, perhaps make it a separate commit 
> describing
> 
> the issue.
> 
> 
> Konrad
> 

Before removing reading msm-id in qcom_cpufreq_nvmem, bits 0-2 (0x07) 
were MSM8996 speed bins, while bits 4-6 (0x70) were MSM8996 Pro speed 
bins. Now, only bits 0-2 are used for either one, so basically I moved 
bits 4-6 into msm8996pro.dtsi after shifting them right to become bits 
0-2.

I'll put this in a separate patch and describe the change.

	Yassine