linux-kernel - Re: [PATCH 0/3] serial: 8250: fix racy uartclk update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211016152521.zmzhtkswhphos4q7@mobilestation>
Date:   Sat, 16 Oct 2021 18:25:21 +0300
From:   Serge Semin <Sergey.Semin@...kalelectronics.ru>
To:     Johan Hovold <johan@...nel.org>
CC:     Serge Semin <fancer.lancer@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] serial: 8250: fix racy uartclk update

Hello Johan

On Fri, Oct 15, 2021 at 10:10:00PM +0300, Serge Semin wrote:
> On Fri, Oct 15, 2021 at 01:14:19PM +0200, Johan Hovold wrote:
> > Here's a fix for the asynchronous uartclk-update hack which was added
> > last year and a couple of related clean ups.
> 
> Yeah, that was very unfortunate patchset. Thank you very much for the fix.
> I'll test it out tomorrow.
> 
> -Sergey

The series has been tested on Baikal-T1 SoC with two UART ports
feed with a common reference clock. It's working well. Thanks again
for fixing the problem. For the whole series
Reviewed-by: Serge Semin <fancer.lancer@...il.com>
Tested-by: Serge Semin <fancer.lancer@...il.com>

-Sergey

> 
> > 
> > Johan
> > 
> > 
> > Johan Hovold (3):
> >   serial: 8250: fix racy uartclk update
> >   serial: 8250: rename unlock labels
> >   serial: 8250_dw: drop bogus uartclk optimisation
> > 
> >  drivers/tty/serial/8250/8250_dw.c   | 11 ++++------
> >  drivers/tty/serial/8250/8250_port.c | 31 ++++++++++++++++++++---------
> >  2 files changed, 26 insertions(+), 16 deletions(-)
> > 
> > -- 
> > 2.32.0
> >