linux-kernel - Re: [PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 16 Oct 2021 18:03:22 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: cpcap-pwrbutton - do not set input parent
 explicitly

Hi,

On Fri, Oct 15, 2021 at 10:25:58PM -0700, Dmitry Torokhov wrote:
> We are using devm_input_allocate_device() that already sets parent
> of the input device, there is no need to do that again.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

>  drivers/input/misc/cpcap-pwrbutton.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c
> index 372cb44d0635..879790bbf9fe 100644
> --- a/drivers/input/misc/cpcap-pwrbutton.c
> +++ b/drivers/input/misc/cpcap-pwrbutton.c
> @@ -77,7 +77,6 @@ static int cpcap_power_button_probe(struct platform_device *pdev)
>  
>  	button->idev->name = "cpcap-pwrbutton";
>  	button->idev->phys = "cpcap-pwrbutton/input0";
> -	button->idev->dev.parent = button->dev;
>  	input_set_capability(button->idev, EV_KEY, KEY_POWER);
>  
>  	err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> -- 
> 2.33.0.1079.g6e70778dc9-goog
> 
> 
> -- 
> Dmitry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)