linux-kernel - Re: [PATCH v3 1/5] mwifiex: Don't log error on suspend if wake-on-wlan is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d16c5fa8d6dd2424cc5a136a879e88b90ec0345.camel@perches.com>
Date:   Sat, 16 Oct 2021 10:50:25 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jonas Dreßler <verdre@...d.nl>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        Ganapathi Bhat <ganapathi017@...il.com>,
        Xinming Hu <huxinming820@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Tsuchiya Yuto <kitakar@...il.com>, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Maximilian Luz <luzmaximilian@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH v3 1/5] mwifiex: Don't log error on suspend if
 wake-on-wlan is disabled

On Sat, 2021-10-16 at 17:32 +0200, Jonas Dreßler wrote:
> It's not an error if someone chooses to put their computer to sleep, not
> wanting it to wake up because the person next door has just discovered
> what a magic packet is. So change the loglevel of this annoying message
> from ERROR to INFO.
> 
> Signed-off-by: Jonas Dreßler <verdre@...d.nl>
> ---
>  drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index ef697572a293..987558c4fc79 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -3492,7 +3492,7 @@ static int mwifiex_cfg80211_suspend(struct wiphy *wiphy,
>  	}
>  
>  	if (!wowlan) {
> -		mwifiex_dbg(adapter, ERROR,
> +		mwifiex_dbg(adapter, INFO,
>  			    "None of the WOWLAN triggers enabled\n");

None of these are have a loglevel of KERN_ERR,
all of these are logged at KERN_INFO.

What I don't understand is why mwifiex_dbg is using KERN_INFO at all
and not KERN_DEBUG.

[]

drivers/net/wireless/marvell/mwifiex/main.h:#define mwifiex_dbg(adapter, mask, fmt, ...)                                \
drivers/net/wireless/marvell/mwifiex/main.h-    _mwifiex_dbg(adapter, MWIFIEX_DBG_##mask, fmt, ##__VA_ARGS__)

[]

drivers/net/wireless/marvell/mwifiex/main.c:void _mwifiex_dbg(const struct mwifiex_adapter *adapter, int mask,
drivers/net/wireless/marvell/mwifiex/main.c-              const char *fmt, ...)
drivers/net/wireless/marvell/mwifiex/main.c-{
drivers/net/wireless/marvell/mwifiex/main.c-    struct va_format vaf;
drivers/net/wireless/marvell/mwifiex/main.c-    va_list args;
drivers/net/wireless/marvell/mwifiex/main.c-
drivers/net/wireless/marvell/mwifiex/main.c-    if (!(adapter->debug_mask & mask))
drivers/net/wireless/marvell/mwifiex/main.c-            return;
drivers/net/wireless/marvell/mwifiex/main.c-
drivers/net/wireless/marvell/mwifiex/main.c-    va_start(args, fmt);
drivers/net/wireless/marvell/mwifiex/main.c-
drivers/net/wireless/marvell/mwifiex/main.c-    vaf.fmt = fmt;
drivers/net/wireless/marvell/mwifiex/main.c-    vaf.va = &args;
drivers/net/wireless/marvell/mwifiex/main.c-
drivers/net/wireless/marvell/mwifiex/main.c-    if (adapter->dev)
drivers/net/wireless/marvell/mwifiex/main.c-            dev_info(adapter->dev, "%pV", &vaf);
drivers/net/wireless/marvell/mwifiex/main.c-    else
drivers/net/wireless/marvell/mwifiex/main.c-            pr_info("%pV", &vaf);
drivers/net/wireless/marvell/mwifiex/main.c-
drivers/net/wireless/marvell/mwifiex/main.c-    va_end(args);
drivers/net/wireless/marvell/mwifiex/main.c-}
drivers/net/wireless/marvell/mwifiex/main.c:EXPORT_SYMBOL_GPL(_mwifiex_dbg);