linux-kernel - Re: [PATCH] ieee802154: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 16 Oct 2021 22:54:52 +0200
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        h.morris@...coda.com, alex.aring@...il.com, davem@...emloft.net,
        kuba@...nel.org
Cc:     linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ieee802154: Remove redundant 'flush_workqueue()' calls

Hello Dave, Jakub.

I have nothing else in my ieee802154 tree for net right now so it would 
be great if you could take it directly. If that poses a problem, let me 
know and I will get it in through my tree.

On 14.10.21 20:26, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> This was generated with coccinelle:
> 
> @@
> expression E;
> @@
> - 	flush_workqueue(E);
> 	destroy_workqueue(E);
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/net/ieee802154/ca8210.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index 3a2824f24caa..ece6ff6049f6 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2938,9 +2938,7 @@ static int ca8210_dev_com_init(struct ca8210_priv *priv)
>    */
>   static void ca8210_dev_com_clear(struct ca8210_priv *priv)
>   {
> -	flush_workqueue(priv->mlme_workqueue);
>   	destroy_workqueue(priv->mlme_workqueue);
> -	flush_workqueue(priv->irq_workqueue);
>   	destroy_workqueue(priv->irq_workqueue);
>   }
>   
> 

Thanks Christophe for spotting and fixing this.

Signed-off-by: Stefan Schmidt <stefan@...enfreihafen.org>

regards
Stefan Schmidt