linux-kernel - Re: [RFC PATCH v2] workqueue: Introduce __show_worker_pool_state and __show_workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 16 Oct 2021 11:26:43 +1100
From:   imran.f.khan@...cle.com
To:     Tejun Heo <tj@...nel.org>
Cc:     jiangshanlai@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2] workqueue: Introduce __show_worker_pool_state and
 __show_workqueue_state.

Hi Tejun,
Sorry for getting back late on this.

On 12/10/21 3:48 am, Tejun Heo wrote:
> On Wed, Oct 06, 2021 at 08:38:41AM +1100, Imran Khan wrote:
>> So divide show_workqueue_state into more granular functions
>> (__show_workqueue_state and __show_worker_pool_state), that would show
> 
> This is nit-picky but can we please name them sth like
> show_one_workqueue_state() and show_one_worker_pool_state() or just
> show_one_workqueue() and show_one_worker_pool() with the corresponding
> versions renamed to show_all_workqueues() and show_all_worker_pools()?
> 

Yes. This sounds good to me. I have renamed the functions as 
show_one_workqueue() and show_one_worker_pool(). On the same lines I 
have renamed show_workqueue_state() to show_all_workqueues(). These 
changes are available in v3 of the patch [1].

[1] 
https://lore.kernel.org/lkml/20211016002007.143661-1-imran.f.khan@oracle.com/

Thanks again for reviewing this.

  -- Imran
> Thanks.
>