lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Oct 2021 13:23:47 +0200 From: Michael Straube <straube.linux@...il.com> To: Martin Kaiser <martin@...ser.cx>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Larry Finger <Larry.Finger@...inger.net>, Phillip Potter <phil@...lpotter.co.uk>, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/8] staging: r8188eu: remove empty trigger gpio code On 10/16/21 13:30, Martin Kaiser wrote: > The hal variable HW_VAR_TRIGGER_GPIO_0 and the rtl8192cu_trigger_gpio_0 > function are not used. Remove them. > > Signed-off-by: Martin Kaiser <martin@...ser.cx> > --- > drivers/staging/r8188eu/hal/usb_halinit.c | 8 -------- > drivers/staging/r8188eu/include/hal_intf.h | 1 - > 2 files changed, 9 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c > index abbd107ad3c1..cdc602fa9af8 100644 > --- a/drivers/staging/r8188eu/hal/usb_halinit.c > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c > @@ -1087,11 +1087,6 @@ void ReadAdapterInfo8188EU(struct adapter *Adapter) > _ReadAdapterInfo8188EU(Adapter); > } > > -#define GPIO_DEBUG_PORT_NUM 0 > -static void rtl8192cu_trigger_gpio_0(struct adapter *adapt) > -{ > -} > - > static void ResumeTxBeacon(struct adapter *adapt) > { > struct hal_data_8188e *haldata = GET_HAL_DATA(adapt); > @@ -1657,9 +1652,6 @@ void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val) > } > } > break; > - case HW_VAR_TRIGGER_GPIO_0: > - rtl8192cu_trigger_gpio_0(Adapter); > - break; > case HW_VAR_RPT_TIMER_SETTING: > { > u16 min_rpt_time = (*(u16 *)val); > diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h > index 408168284b3f..d777ad9071e2 100644 > --- a/drivers/staging/r8188eu/include/hal_intf.h > +++ b/drivers/staging/r8188eu/include/hal_intf.h > @@ -55,7 +55,6 @@ enum hw_variables { > HW_VAR_TDLS_RS_RCR, > HW_VAR_TDLS_DONE_CH_SEN, > HW_VAR_INITIAL_GAIN, > - HW_VAR_TRIGGER_GPIO_0, > HW_VAR_BT_SET_COEXIST, > HW_VAR_BT_ISSUE_DELBA, > HW_VAR_CURRENT_ANTENNA, > Acked-by: Michael Straube <straube.linux@...il.com>
Powered by blists - more mailing lists