linux-kernel - Re: [PATCH 8/8] staging: r8188eu: CurrentWirelessMode is not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 Oct 2021 13:57:30 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] staging: r8188eu: CurrentWirelessMode is not used

On 10/16/21 13:30, Martin Kaiser wrote:
> CurrentWirelessMode in struct hal_data_8188e is not used. Remove the
> component and the enum with its possible values.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>   drivers/staging/r8188eu/include/Hal8188EPhyCfg.h | 8 --------
>   drivers/staging/r8188eu/include/rtl8188e_hal.h   | 1 -
>   2 files changed, 9 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h b/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h
> index 58377edf724d..6f901ce607e8 100644
> --- a/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h
> +++ b/drivers/staging/r8188eu/include/Hal8188EPhyCfg.h
> @@ -48,14 +48,6 @@ enum rf_radio_path {
>   						 * total three groups */
>   #define CHANNEL_GROUP_MAX_88E		6
>   
> -enum wireless_mode {
> -	WIRELESS_MODE_UNKNOWN = 0x00,
> -	WIRELESS_MODE_B			= BIT(0),
> -	WIRELESS_MODE_G			= BIT(1),
> -	WIRELESS_MODE_AUTO		= BIT(5),
> -	WIRELESS_MODE_N_24G		= BIT(3),
> -};
> -
>   /* BB/RF related */
>   enum RF_TYPE_8190P {
>   	RF_TYPE_MIN,		/*  0 */
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index 5fdee1c6299c..ced7e12d9013 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -162,7 +162,6 @@ struct hal_data_8188e {
>   	u8	PGMaxGroup;
>   	/* current WIFI_PHY values */
>   	u32	ReceiveConfig;
> -	enum wireless_mode CurrentWirelessMode;
>   	enum ht_channel_width CurrentChannelBW;
>   	u8	CurrentChannel;
>   	u8	nCur40MhzPrimeSC;/*  Control channel sub-carrier */
> 

Acked-by: Michael Straube <straube.linux@...il.com>