linux-kernel - Re: [PATCH v3 1/2] dt-bindings: mailbox: Add Apple mailbox bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 Oct 2021 17:42:40 +0200
From:   "Sven Peter" <sven@...npeter.dev>
To:     "Rob Herring" <robh@...nel.org>
Cc:     "Jassi Brar" <jassisinghbrar@...il.com>,
        "Mohamed Mediouni" <mohamed.mediouni@...amail.com>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Hector Martin" <marcan@...can.st>, linux-kernel@...r.kernel.org,
        "Alyssa Rosenzweig" <alyssa@...enzweig.io>,
        "Mark Kettenis" <kettenis@...nbsd.org>,
        "Stan Skowronek" <stan@...ellium.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        "Mark Kettenis" <mark.kettenis@...all.nl>
Subject: Re: [PATCH v3 1/2] dt-bindings: mailbox: Add Apple mailbox bindings

On Sun, Oct 17, 2021, at 17:29, Rob Herring wrote:
> On Sun, 17 Oct 2021 13:40:53 +0200, Sven Peter wrote:
>> Apple mailbox controller are found on the M1 and are used for
>> communication with various co-processors.
>> 
>> Reviewed-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
>> Reviewed-by: Mark Kettenis <kettenis@...nbsd.org>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> Signed-off-by: Sven Peter <sven@...npeter.dev>
>> ---
>>  .../bindings/mailbox/apple,mailbox.yaml       | 79 +++++++++++++++++++
>>  MAINTAINERS                                   |  1 +
>>  2 files changed, 80 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
>> 
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml: 
> properties:interrupts: 'oneOf' conditional failed, one must be fixed:
> 	[{'description': 'send fifo is empty interrupt'}, {'description': 
> 'send fifo is not empty interrupt'}, {'description': 'receive fifo is 
> empty interrupt'}, {'description': 'receive fifo is not empty 
> interrupt'}] is too long
> 	[{'description': 'send fifo is empty interrupt'}, {'description': 
> 'send fifo is not empty interrupt'}, {'description': 'receive fifo is 
> empty interrupt'}, {'description': 'receive fifo is not empty 
> interrupt'}] is too short
> 	False schema does not allow 4
> 	1 was expected
> 	4 is greater than the maximum of 2
> 	4 is greater than the maximum of 3
> 	hint: "minItems" is only needed if less than the "items" list length
> 	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml: 
> properties:interrupt-names: 'oneOf' conditional failed, one must be 
> fixed:
> 	[{'const': 'send-empty'}, {'const': 'send-not-empty'}, {'const': 
> 'recv-empty'}, {'const': 'recv-not-empty'}] is too long
> 	[{'const': 'send-empty'}, {'const': 'send-not-empty'}, {'const': 
> 'recv-empty'}, {'const': 'recv-not-empty'}] is too short
> 	False schema does not allow 4
> 	1 was expected
> 	4 is greater than the maximum of 2
> 	4 is greater than the maximum of 3
> 	hint: "minItems" is only needed if less than the "items" list length
> 	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml: 
> ignoring, error in schema: properties: interrupts
> warning: no schema found in file: 
> ./Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
> Documentation/devicetree/bindings/mailbox/apple,mailbox.example.dt.yaml:0:0: 
> /example-0/mailbox@...08000: failed to match any schema with 
> compatible: ['apple,t8103-asc-mailbox']
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/1542209
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.


Whoops, looks like this fails some new check added since I submitted
the last version a month ago.
I'll drop the "minItems: 4" since the number of items is constant anyway.


Sven