linux-kernel - Re: [PATCH] counter/counter-sysfs: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Oct 2021 08:33:34 +0900
From:   William Breathitt Gray <vilhelm.gray@...il.com>
To:     David Lechner <david@...hnology.com>, jic23@...nel.org
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] counter/counter-sysfs: use sysfs_emit everywhere

On Sun, Oct 17, 2021 at 02:01:06PM -0500, David Lechner wrote:
> In the counter subsystem, we are already using sysfs_emit(), but there
> were a few places where we were still using sprintf() in *_show()
> functions. For consistency and added protections, use sysfs_emit()
> everywhere.
> 
> Suggested-by: Greg KH <gregkh@...uxfoundation.org>
> Signed-off-by: David Lechner <david@...hnology.com>

Acked-by: William Breathitt Gray <vilhelm.gray@...il.com>

> ---
>  drivers/counter/counter-sysfs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/counter/counter-sysfs.c b/drivers/counter/counter-sysfs.c
> index 7bf8882ff54d..8c2d7c29ea59 100644
> --- a/drivers/counter/counter-sysfs.c
> +++ b/drivers/counter/counter-sysfs.c
> @@ -113,7 +113,7 @@ static ssize_t counter_comp_u8_show(struct device *dev,
>  		/* data should already be boolean but ensure just to be safe */
>  		data = !!data;
>  
> -	return sprintf(buf, "%u\n", (unsigned int)data);
> +	return sysfs_emit(buf, "%u\n", (unsigned int)data);
>  }
>  
>  static ssize_t counter_comp_u8_store(struct device *dev,
> @@ -196,7 +196,7 @@ static ssize_t counter_comp_u32_show(struct device *dev,
>  	case COUNTER_COMP_COUNT_MODE:
>  		return sysfs_emit(buf, "%s\n", counter_count_mode_str[data]);
>  	default:
> -		return sprintf(buf, "%u\n", (unsigned int)data);
> +		return sysfs_emit(buf, "%u\n", (unsigned int)data);
>  	}
>  }
>  
> @@ -300,7 +300,7 @@ static ssize_t counter_comp_u64_show(struct device *dev,
>  	if (err < 0)
>  		return err;
>  
> -	return sprintf(buf, "%llu\n", (unsigned long long)data);
> +	return sysfs_emit(buf, "%llu\n", (unsigned long long)data);
>  }
>  
>  static ssize_t counter_comp_u64_store(struct device *dev,
> @@ -539,7 +539,7 @@ static ssize_t counter_comp_id_show(struct device *dev,
>  {
>  	const size_t id = (size_t)to_counter_attribute(attr)->comp.priv;
>  
> -	return sprintf(buf, "%zu\n", id);
> +	return sysfs_emit(buf, "%zu\n", id);
>  }
>  
>  static int counter_comp_id_attr_create(struct device *const dev,
> -- 
> 2.25.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)