linux-kernel - Re: [Outreachy kernel] [PATCH] staging: vc04_services: Fixed checkpatch warning: MSLEEP: msleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2110170813570.3026@hadrien>
Date:   Sun, 17 Oct 2021 08:17:45 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Kushal-kothari <kushalkothari285@...il.com>
cc:     linux-arm-kernel@...ts.infradead.org, mike.rapoport@...il.com,
        kushalkothari2850@...il.com, outreachy-kernel@...glegroups.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, nsaenz@...nel.org,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [Outreachy kernel] [PATCH] staging: vc04_services: Fixed checkpatch
 warning: MSLEEP: msleep < 20ms can sleep for up to 20ms.



On Sun, 17 Oct 2021, Kushal-kothari wrote:

> Signed-off-by: Kushal-kothari <kushalkothari285@...il.com>

You need a log message.  The whole thing should not be in the subject
line.  The description of the change should be written in the imperative,
that is Fix instead of Fixed.  But in any case Fix is not a good word to
use because it does not explain what you have done.  What fix have you
implemented.  The log message should explain what you have done and why.

Please carefully read the entire page:

https://kernelnewbies.org/PatchPhilosophy

Please check your patch against what is suggested.

julia


> ---
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index 6fbafdfe340f..80a7898c5331 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -857,7 +857,7 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size,
>  		if (status != VCHIQ_RETRY)
>  			break;
>
> -		msleep(1);
> +		usleep_range(1000, 2000);
>  	}
>
>  	return status;
> @@ -894,7 +894,7 @@ enum vchiq_status vchiq_bulk_receive(unsigned int handle, void *data,
>  		if (status != VCHIQ_RETRY)
>  			break;
>
> -		msleep(1);
> +		usleep_range(1000, 2000);
>  	}
>
>  	return status;
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20211016215527.119189-1-kushalkothari285%40gmail.com.
>