linux-kernel - Re: [RFC PATCH] sound: ISA: not for M68K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 17 Oct 2021 09:03:56 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-m68k@...ts.linux-m68k.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [RFC PATCH] sound: ISA: not for M68K

On Sat, 16 Oct 2021 08:26:02 +0200,
Randy Dunlap wrote:
> 
> On m68k, compiling drivers under SND_ISA causes build errors:
> 
> ../sound/core/isadma.c: In function 'snd_dma_program':
> ../sound/core/isadma.c:33:17: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
>    33 |         flags = claim_dma_lock();
>       |                 ^~~~~~~~~~~~~~
> ../sound/core/isadma.c:41:9: error: implicit declaration of function 'release_dma_lock' [-Werror=implicit-function-declaration]
>    41 |         release_dma_lock(flags);
>       |         ^~~~~~~~~~~~~~~~
> 
> ../sound/isa/sb/sb16_main.c: In function 'snd_sb16_playback_prepare':
> ../sound/isa/sb/sb16_main.c:253:72: error: 'DMA_AUTOINIT' undeclared (first use in this function)
>   253 |         snd_dma_program(dma, runtime->dma_addr, size, DMA_MODE_WRITE | DMA_AUTOINIT);
>       |                                                                        ^~~~~~~~~~~~
> ../sound/isa/sb/sb16_main.c:253:72: note: each undeclared identifier is reported only once for each function it appears in
> ../sound/isa/sb/sb16_main.c: In function 'snd_sb16_capture_prepare':
> ../sound/isa/sb/sb16_main.c:322:71: error: 'DMA_AUTOINIT' undeclared (first use in this function)
>   322 |         snd_dma_program(dma, runtime->dma_addr, size, DMA_MODE_READ | DMA_AUTOINIT);
>       |                                                                       ^~~~~~~~~~~~
> 
> and more...
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.com>
> Cc: alsa-devel@...a-project.org
> Cc: linux-m68k@...ts.linux-m68k.org
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks, applied.


Takashi