lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Oct 2021 11:37:30 +0200 From: Greg KH <gregkh@...uxfoundation.org> To: Kushal-kothari <kushalkothari285@...il.com> Cc: linux-arm-kernel@...ts.infradead.org, mike.rapoport@...il.com, kushalkothari2850@...il.com, outreachy-kernel@...glegroups.com, linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev, nsaenz@...nel.org, bcm-kernel-feedback-list@...adcom.com Subject: Re: [PATCH v2] staging: vc04_services: replace msleep() by usleep_range() On Sun, Oct 17, 2021 at 02:59:00PM +0530, Kushal-kothari wrote: > Fixed the warning:-msleep < 20ms can sleep for up to 20ms by replacing > msleep(unsigned long msecs) by usleep_range(unsigned long min, unsigned long max) No need to put the parameters in a function call. > in usecs as msleep(1ms~20ms) can sleep for upto 20 ms. > > Signed-off-by: Kushal-kothari <kushalkothari285@...il.com> We need a "Legal" name here, is that how you sign documents? Sorry, I have to ask. > --- > > Changes from v1: Reword both the subject and the log message. > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 6fbafdfe340f..80a7898c5331 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -857,7 +857,7 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size, > if (status != VCHIQ_RETRY) > break; > > - msleep(1); > + usleep_range(1000, 2000); You can not just randomly pick a range value here without lots of testing and knowing that the hardware really can support this. Have you done this here? thanks, greg k-h
Powered by blists - more mailing lists