linux-kernel - Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211018135421.gnjbkuvrmjep2odz@bogus>
Date:   Mon, 18 Oct 2021 14:54:21 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        jing yangyang <cgel.zte@...il.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        jing yangyang <jing.yangyang@....com.cn>,
        Zeal Robot <zealci@....com.cn>, linux-hardening@...r.kernel.org
Subject: Re: [PATCH linux-next] firmware/psci: fix application of sizeof to
 pointer

On Sat, Oct 16, 2021 at 01:10:03PM -0500, Gustavo A. R. Silva wrote:
> On Tue, Aug 24, 2021 at 11:58:24AM +0100, Mark Rutland wrote:
> > On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote:
> > > sizeof when applied to a pointer typed expression gives the size of
> > > the pointer.
> > > 
> > > ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer
> > > 
> > > This issue was detected with the help of Coccinelle.
> > > 
> > > Reported-by: Zeal Robot <zealci@....com.cn>
> > > Signed-off-by: jing yangyang <jing.yangyang@....com.cn>
> > 
> > >From looking at the git history, we should add:
> > 
> >   Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)"
> > 
> > With that:
> > 
> >   Acked-by: Mark Rutland <mark.rutland@....com>
> > 
> > Lorenzo, how do we normally direct these patches?
> 
> It seems that these patches are consistently being ignored[1][2][3]. So,

Sorry for that. Sometime it does happen. Anyways thanks for reminding about
it.

> I'll take this in my -next tree[4] before it gets lost again.

Mark has already acked it, so you can take it via your tree if you are OK.

We generally ask the author to post to soc@...nel.org for one of patches
like this when we don't have any plans to send PR to SoC team so that they
can apply the patch directly.

So it should be fine if you prefer to pick up and send to SoC team or we
can resend the patch to them and ask to apply. Let us know.

-- 
Regards,
Sudeep