linux-kernel - Re: [PATCH] mfd: altera-sysmgr: Fix a mistake caused by resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Oct 2021 15:02:34 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Kai Song <songkai01@...pur.com>
Cc:     thor.thayer@...ux.intel.com, zou_wei@...wei.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: altera-sysmgr: Fix a mistake caused by
 resource_size function

On Wed, 06 Oct 2021, Kai Song wrote:

> Fixes: d12edf9661a4 ("mfd: altera-sysmgr: Use resource_size function on resource object")
> 
> The resource_size defines that:
> 	res->end - res->start + 1;
> The origin original code is:
> 	sysmgr_config.max_register = res->end - res->start - 3;
> 
> So, the correct fix is that:
> 	sysmgr_config.max_register = resource_size(res) - 4;
> 
> Signed-off-by: Kai Song <songkai01@...pur.com>
> ---
>  drivers/mfd/altera-sysmgr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog