linux-kernel - Re: [PATCH] hwmon: (tmp421) Add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211018142421.GA1151312@roeck-us.net>
Date:   Mon, 18 Oct 2021 07:24:21 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, kael_w@...h.net
Subject: Re: [PATCH] hwmon: (tmp421) Add of_node_put() before return

On Mon, Oct 18, 2021 at 08:15:37AM -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/hwmon/tmp421.c:416:1-23: WARNING: Function
> for_each_child_of_node should have of_node_put() before return.
> 
> Early exits from for_each_child_of_node should decrement the
> node reference counter.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/tmp421.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
> index 31e95b5749c8..1fd8d41d90c8 100644
> --- a/drivers/hwmon/tmp421.c
> +++ b/drivers/hwmon/tmp421.c
> @@ -418,8 +418,10 @@ static int tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *d
>  			continue;
>  
>  		err = tmp421_probe_child_from_dt(client, child, data);
> -		if (err)
> +		if (err) {
> +			of_node_put(child);
>  			return err;
> +		}
>  	}
>  
>  	return 0;