linux-kernel - Re: [PATCH] [v2] bcache: hide variable-sized types from uapi header check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Oct 2021 23:26:37 +0800
From:   Coly Li <colyli@...e.de>
To:     Christoph Hellwig <hch@....de>, Arnd Bergmann <arnd@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Jens Axboe <axboe@...nel.dk>,
        Kent Overstreet <kmo@...erainc.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v2] bcache: hide variable-sized types from uapi header
 check

On 10/18/21 11:22 PM, Christoph Hellwig wrote:
> On Mon, Oct 18, 2021 at 10:42:37PM +0800, Coly Li wrote:
>> I am quite open for this idea. It is in uapi directory before I maintain
>> bcache. I just though the header fines on-media format should go into
>> include/uapi/, but if this is not the restricted rule, it is fine for me to
>> move this header to drivers/md/bcache/.
> Treating the on-disk definitions as a UAPI doesn't make much sense to
> me.  I like keeping it in a separate header to make clear what is the
> on-disk format and what is just in core, but it should normally live
> with the rest of the code.

Hi Christoph,

Thanks for the input. So it is fine for me to have the header in 
drivers/md/bcache.

Hi Arnd,

There is another bcache.h in drivers/md/bcache/, let me handle the 
header naming issue, and I will post a change to move the bcache.h from 
include/uapi/linux to driver/md/bcache later.
And I will ask you to help to review the change.

Coly Li