linux-kernel - Re: [PATCH v2 10/18] input&tty: Fix the keyboard led light display problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YW0ASOPjFT8diKQq@google.com>
Date:   Sun, 17 Oct 2021 22:04:08 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     changlianzhi <changlianzhi@...ontech.com>
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, andriy.shevchenko@...ux.intel.com,
        linux-input@...r.kernel.org, 282827961@...com
Subject: Re: [PATCH v2 10/18] input&tty: Fix the keyboard led light display
 problem

Hi,

On Mon, Oct 18, 2021 at 10:01:34AM +0800, changlianzhi wrote:
> Switching from the desktop environment to the tty environment,
> the state of the keyboard led lights and the state of the keyboard
> lock are inconsistent. This is because the attribute kb->kbdmode
> of the tty bound in the desktop environment (xorg) is set to
> VC_OFF, which causes the ledstate and kb->ledflagstate
> values of the bound tty to always be 0, which causes the switch
> from the desktop When to the tty environment, the LED light
> status is inconsistent with the keyboard lock status.
> 
> Signed-off-by: lianzhi chang <changlianzhi@...ontech.com>
> ---
> v2 10/18:
> (1) Move the definition of ledstate to the input module
> (/drivers/input/input.c),
> and set or get its value through the input_update_ledstate(Replace the
> update_value_ledstate function defined in the last patch, and optimize
> the code according to the proposal) and input_get_ledstate functions.
> (2) To update the ledstate reference in keyboard.c, you must first get
> the value through input_get_ledstate.
> (3)Some macro definitions have been added to input.c.
> 
> drivers/input/input.c | 46 ++++++++++++++++++++++++++++++++++++++-

As I mentioned, I do not see a reason for your patch to touch input
core, please keep the modifications contained within
drivers/tty/vt/keyboard.c

> drivers/tty/vt/keyboard.c | 19 ++++++++++++++--
> include/linux/input.h | 3 +++
> 3 files changed, 65 insertions(+), 3 deletions(-)
> 

Thanks.

-- 
Dmitry