linux-kernel - RE: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Oct 2021 09:06:57 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Wan Jiabing <wanjiabing@...o.com>, Shuah Khan <shuah@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, linux-kselftest@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kael_w@...h.net, Wan Jiabing <wanjiabing@...o.com>
Subject: RE: [PATCH] [v2] selftests: bpf: Remove duplicated include in
 cgroup_helpers

Wan Jiabing wrote:
> Fix following checkincludes.pl warning:
> ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
> tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
> than once.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
> Changelog:
> v2:
> - Fix the commit description.
> ---

The Subject is a bit unusual. Typically it would be something like,

 "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"

For the actual patch though LGTM.

Acked-by: John Fastabend <john.fastabend@...il.com>