linux-kernel - Re: [PATCH 1/3] x86/insn-eval: Introduce insn_get_modrm_reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211018164436.saj47igl53bnd3r3@box.shutemov.name>
Date:   Mon, 18 Oct 2021 19:44:36 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Tom Lendacky <thomas.lendacky@....com>,
        Joerg Roedel <jroedel@...e.de>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Sean Christopherson <seanjc@...gle.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH 1/3] x86/insn-eval: Introduce insn_get_modrm_reg_ptr()

On Mon, Oct 18, 2021 at 05:47:17PM +0200, Peter Zijlstra wrote:
> On Mon, Oct 18, 2021 at 06:33:31PM +0300, Kirill A. Shutemov wrote:
> > +/**
> > + * insn_get_modrm_reg_ptr() - Obtain register pointer based on ModRM byte
> > + * @insn:	Instruction containing the ModRM byte
> > + * @regs:	Register values as seen when entering kernel mode
> > + *
> > + * Returns:
> > + *
> > + * The register indicated by the reg part of the ModRM byte.
> > + * The register is obtained as a pointer within pt_regs.
> > + */
> > +void *insn_get_modrm_reg_ptr(struct insn *insn, struct pt_regs *regs)
> 
> Doesn't that return type want to be 'unsigned long *'?

Right, will fix.

-- 
 Kirill A. Shutemov