linux-kernel - Re: [PATCH v4] mm: page_alloc: Add debug log in free_reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211018110002.596d03206aa849eec06d11f5@linux-foundation.org>
Date:   Mon, 18 Oct 2021 11:00:02 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Faiyaz Mohammed <faiyazm@...eaurora.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org, david@...hat.com,
        guptap@...eaurora.org, Mike Rapoport <rppt@...nel.org>
Subject: Re: [PATCH v4] mm: page_alloc: Add debug log in free_reserved_area
 for static memory

On Mon, 18 Oct 2021 12:24:13 +0530 Faiyaz Mohammed <faiyazm@...eaurora.org> wrote:

> For INITRD and initmem memory is reserved through "memblock_reserve"
> during boot up but it is free via "free_reserved_area" instead
> of "memblock_free".
> For example:
> [    0.294848] Freeing initrd memory: 12K.
> [    0.696688] Freeing unused kernel memory: 4096K.
> 
> To get the start and end address of the above freed memory and to account
> proper memblock added pr_debug log in "free_reserved_area".
> After adding log:
> [    0.294837] 0x00000083600000-0x00000083603000 free_initrd_mem+0x20/0x28
> [    0.294848] Freeing initrd memory: 12K.
> [    0.695246] 0x00000081600000-0x00000081a00000 free_initmem+0x70/0xc8
> [    0.696688] Freeing unused kernel memory: 4096K.

The above log appears to have things backwards.  I assume you meant

> [    0.294848] Freeing initrd memory: 12K.
> [    0.294837] 0x00000083600000-0x00000083603000 free_initrd_mem+0x20/0x28
> [    0.696688] Freeing unused kernel memory: 4096K.
> [    0.695246] 0x00000081600000-0x00000081a00000 free_initmem+0x70/0xc8