linux-kernel - Re: [PATCH] KVM: cleanup allocation of rmaps and page tracking data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YW25ZiTE1N6xS4FN@google.com>
Date:   Mon, 18 Oct 2021 18:13:58 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        David Stevens <stevensd@...omium.org>
Subject: Re: [PATCH] KVM: cleanup allocation of rmaps and page tracking data

On Mon, Oct 18, 2021, Paolo Bonzini wrote:
> From: David Stevens <stevensd@...omium.org>
> 
> Unify the flags for rmaps and page tracking data, using a
> single flag in struct kvm_arch and a single loop to go
> over all the address spaces and memslots.  This avoids
> code duplication between alloc_all_memslots_rmaps and
> kvm_page_track_enable_mmu_write_tracking.
> 
> Signed-off-by: David Stevens <stevensd@...omium.org>
> [This patch is the delta between David's v2 and v3, with conflicts
>  fixed and my own commit message. - Paolo]
> Co-developed-by: Sean Christopherson <seanjc@...gle.com>

Checkpatch will complain about a lack of 

	Signed-off-by: Sean Christopherson <seanjc@...gle.com>

> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---

...

> +	bool shadow_root_alloced;

Maybe "allocated" instead of "alloced"?