linux-kernel - RE: [PATCH v2] blk-mq: Fix blk_mq_tagset_busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f09315210261e82c42a1353cab48dcd@mail.gmail.com>
Date:   Tue, 19 Oct 2021 00:19:13 +0530
From:   Kashyap Desai <kashyap.desai@...adcom.com>
To:     John Garry <john.garry@...wei.com>, axboe@...nel.dk
Cc:     ming.lei@...hat.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, hare@...e.de
Subject: RE: [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared tags

> -----Original Message-----
> From: John Garry [mailto:john.garry@...wei.com]
> Sent: Monday, October 18, 2021 3:11 PM
> To: axboe@...nel.dk
> Cc: ming.lei@...hat.com; linux-block@...r.kernel.org; linux-
> kernel@...r.kernel.org; kashyap.desai@...adcom.com; hare@...e.de; John
> Garry <john.garry@...wei.com>
> Subject: [PATCH v2] blk-mq: Fix blk_mq_tagset_busy_iter() for shared
tags
>
> Since it is now possible for a tagset to share a single set of tags, the
iter
> function should not re-iter the tags for the count of #hw queues in that
case.
> Rather it should just iter once.
>
> Fixes: e0fdf846c7bb ("blk-mq: Use shared tags for shared sbitmap
support")
> Reported-by: Kashyap Desai <kashyap.desai@...adcom.com>
> Signed-off-by: John Garry <john.garry@...wei.com>
> Reviewed-by: Ming Lei <ming.lei@...hat.com>
> ---
> Diff to v1:
> - Add Ming's RB tag

Now I noticed proper host_busy in my test. Still CPU hogging is not
resolved, but issue addressed by this patch is resolved.

Tested-by: Kashyap Desai <kashyap.desai@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)