linux-kernel - Re: [PATCH] ASoC: rsnd: Fix an error handling path in 'rsnd_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   19 Oct 2021 08:13:35 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, mikhail_durnev@...tor.com, joe@...ches.com,
        pierre-louis.bossart@...ux.intel.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ASoC: rsnd: Fix an error handling path in 'rsnd_node_count()'


Hi

> If we return before the end of the 'for_each_child_of_node()' iterator, the
> reference taken on 'np' must be released.
> 
> Add the missing 'of_node_put()' call.
> 
> Fixes: c413983eb66a ("ASoC: rsnd: adjust disabled module")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto