linux-kernel - Re: WARNING in __init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211018081505.GA28629@lst.de>
Date:   Mon, 18 Oct 2021 10:15:05 +0200
From:   Christoph Hellwig <hch@....de>
To:     Zqiang <qiang.zhang1211@...il.com>
Cc:     Christoph Hellwig <hch@....de>, Hao Sun <sunhao.th@...il.com>,
        Hillf Danton <hdanton@...a.com>, hch@...radead.org,
        willy@...radead.org, Linux MM <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        syzkaller-bugs@...glegroups.com
Subject: Re: WARNING in __init_work

On Mon, Oct 18, 2021 at 03:21:18PM +0800, Zqiang wrote:
> I find in add_partition(),  if the device_add() return error, we will drop 
> disk object reference count,
>
> but i find put_device(pdev) (will call part_release())and put_disk(disk), 
> both will reduce the reference of the disk object , however we call 
> get_device(disk_to_dev(disk)) only once
>
> or Did I miss something and didn't analyze it？

Yes, this sounds correct.  Do you want to send a patch or should I
prepare one?