linux-kernel - Re: [PATCH] counter/counter-sysfs: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YW0vujDgJ12HtulV@kroah.com>
Date:   Mon, 18 Oct 2021 10:26:34 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     William Breathitt Gray <vilhelm.gray@...il.com>
Cc:     David Lechner <david@...hnology.com>, jic23@...nel.org,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] counter/counter-sysfs: use sysfs_emit everywhere

On Mon, Oct 18, 2021 at 05:19:02PM +0900, William Breathitt Gray wrote:
> On Mon, Oct 18, 2021 at 08:06:58AM +0200, Greg KH wrote:
> > On Mon, Oct 18, 2021 at 08:33:34AM +0900, William Breathitt Gray wrote:
> > > On Sun, Oct 17, 2021 at 02:01:06PM -0500, David Lechner wrote:
> > > > In the counter subsystem, we are already using sysfs_emit(), but there
> > > > were a few places where we were still using sprintf() in *_show()
> > > > functions. For consistency and added protections, use sysfs_emit()
> > > > everywhere.
> > > > 
> > > > Suggested-by: Greg KH <gregkh@...uxfoundation.org>
> > > > Signed-off-by: David Lechner <david@...hnology.com>
> > > 
> > > Acked-by: William Breathitt Gray <vilhelm.gray@...il.com>
> > 
> > Thanks, want me to take this directly on top of the previous pull
> > request?
> > 
> > greg k-h
> 
> Yes, that should be a fine path forward for this patch.

Great!  Can you also ack the other patch from David as well?

thanks,

greg k-h