linux-kernel - Re: [PATCH] ASoC: meson: implement driver_name for snd_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1j1r4ivdkc.fsf@starbuckisacylon.baylibre.com>
Date:   Mon, 18 Oct 2021 12:20:03 +0200
From:   Jerome Brunet <jbrunet@...libre.com>
To:     Christian Hewitt <christianshewitt@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kevin Hilman <khilman@...libre.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Matthias Reichl <hias@...us.com>
Subject: Re: [PATCH] ASoC: meson: implement driver_name for snd_soc_card in
 meson-card-utils


On Sun 17 Oct 2021 at 16:00, Christian Hewitt <christianshewitt@...il.com> wrote:

> Implement driver_name to provide an alternative to card_name for userspace
> configuration of Amlogic audio cards.
>
> Suggested-by: Matthias Reichl <hias@...us.com>
> Signed-off-by: Christian Hewitt <christianshewitt@...il.com>
> ---
> The meson AIU/AXG drivers currently require alsa confs based on the board
> model name which is unique to each board. This is very flexible for audio
> use-cases, but not very maintainable for distros with a single use-case
> that need to support a large number of different Amlogic boards. Using a
> driver name to match the card conf instead of card/model name reduces the
> number of confs needed in the LibreELEC (Kodi) distro from 41 to 2.
>
>  sound/soc/meson/meson-card-utils.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/meson/meson-card-utils.c b/sound/soc/meson/meson-card-utils.c
> index 415cc0046e4b..29b0174f4b5c 100644
> --- a/sound/soc/meson/meson-card-utils.c
> +++ b/sound/soc/meson/meson-card-utils.c
> @@ -302,6 +302,7 @@ int meson_card_probe(struct platform_device *pdev)
>  
>  	priv->card.owner = THIS_MODULE;
>  	priv->card.dev = dev;
> +	priv->card.driver_name = dev->driver->name;
>  	priv->match_data = data;

I was preparing something similar to help with alsa-ucm so

Acked-by: Jerome Brunet <jbrunet@...libre.com>

>  
>  	ret = snd_soc_of_parse_card_name(&priv->card, "model");